Strip the scheme value from the OIDC proxy host #26608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
Jul 7, 2022
...on/runtime/src/main/java/io/quarkus/keycloak/pep/runtime/KeycloakPolicyEnforcerRecorder.java
Outdated
Show resolved
Hide resolved
cescoffier
previously requested changes
Jul 8, 2022
...on/runtime/src/main/java/io/quarkus/keycloak/pep/runtime/KeycloakPolicyEnforcerRecorder.java
Outdated
Show resolved
Hide resolved
sberyozkin
force-pushed
the
keycloak_authorization_proxy_scheme
branch
from
17961ee to
266c17a
Compare
gsmet
reviewed
Jul 11, 2022
| adapterConfig.setProxyUrl(oidcConfig.proxy.host.get() + ":" | ||
| + oidcConfig.proxy.port); | ||
| String host = oidcConfig.proxy.host.get(); | ||
| if (!host.startsWith("http")) { |
There was a problem hiding this comment.
I know I'm being a bit pedantic here but I would rather have the test do:
if (!host.startsWith("http://") && !host.startsWith("https://")) {
Because we could imagine someone having a host that is httpfoobar.com.
There was a problem hiding this comment.
Hey @gsmet No problems at all, it is worth avoiding any issues like this one, thanks for spotting it
sberyozkin
force-pushed
the
keycloak_authorization_proxy_scheme
branch
from
266c17a to
78d60b4
Compare
gsmet
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26577.
As described in #26577, Vertx (Mutiny) Web Client will fail if the proxy host is configured as
http://localhost- I have confirmed it,UnknownHostExceptionis reported - withquarkus.oidcusing MutinyWebClient. Whilequarkus-keycloak-authorizationextendingquarkus-oidcand sharing the same proxy configuration will fail unless the host is set ashttp://localhost.So I've done a minor update which 1) strips the
schemefrom a proxyhostvalue if theschemeis set as inhttp://localhostinOidcCommonUtilswhich is used for creatingquarkus-oidcand alsoquarkus-oidc-clientand 2) addshttp://to the host value if it is not already there when configuringkeycloak-authorization.At this moment of time it likely does not really make sense to introduce a
schemeproxy option as it is not directly taken into account withWebClient.